refactor: adding config stem constants #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-wang-yutsung
added
the
tech-debt
bnevis-i
previously approved these changes
Sep 1, 2022
|
@ItsRico DCO check is failing. Need to sign the commit. |
lenny-goodell
requested changes
Sep 1, 2022
Added constants to be common that are previously defined only in edgex-go. Closes: edgexfoundry#754 Signed-off-by: Rico Chavez-Lopez <[email protected]>
Close: edgexfoundry#754 Signed-off-by: Rico Chavez-Lopez <[email protected]>
ItsRico
force-pushed
the
config_const
branch
from
4c0f507 to
2bee4e9
Compare
|
Added missed constant & signed off commits |
Codecov Report
@@ Coverage Diff @@
## main #757 +/- ##
=======================================
Coverage 64.70% 64.70%
=======================================
Files 81 81
Lines 3108 3108
=======================================
Hits 2011 2011
Misses 907 907
Partials 190 190 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bnevis-i
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Adding Config Stem Constants
Added constants to be common that are previously defined only in edgex-go.
Closes: #754
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)